Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CFn schema json name resolution for -ext #9478

Merged
merged 1 commit into from Oct 26, 2023
Merged

Fix CFn schema json name resolution for -ext #9478

merged 1 commit into from Oct 26, 2023

Conversation

dominikschubert
Copy link
Member

Motivation

Since we have resource providers in -ext now, we need to fix the schema json lookup. Since -ext code is encrypted, files are renamed and have an .py.enc file suffix instead of the .py suffix in community.

Changes

  • tries to remove both .py.enc as well as .py when searching for the schema json file.

@dominikschubert dominikschubert self-assigned this Oct 26, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Oct 26, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.612% (+0.01%) from 82.601% when pulling 0c6c679 on fix-cfn-schema-lookup-in-ext into 01bcbe9 on master.

simonrw
simonrw approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for that

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 6m 49s ⏱️
2 285 tests 1 706 ✔️ 579 💤 0 ❌
2 286 runs  1 706 ✔️ 580 💤 0 ❌

Results for commit 0c6c679.

@dominikschubert dominikschubert merged commit 3c981ba into master Oct 26, 2023
29 of 30 checks passed
@dominikschubert dominikschubert deleted the fix-cfn-schema-lookup-in-ext branch October 26, 2023 08:36
pinzon pushed a commit that referenced this pull request Oct 30, 2023
@dominikschubert @pinzon
Fix CFn schema json name resolution for resource providers in -ext (#…
7bd8111 
…9478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dominikschubert @coveralls @simonrw