Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS::SSM::* Resource Provider to CloudFormation #9480

Merged
merged 7 commits into from Nov 8, 2023
Merged

Add AWS::SSM::* Resource Provider to CloudFormation #9480

merged 7 commits into from Nov 8, 2023

Conversation

Morijarti
Copy link
Contributor

@Morijarti Morijarti commented Oct 26, 2023 •
edited

Changes

Added support for:

  • "AWS::SSM::Parameter"
  • "AWS::SSM::MaintenanceWindow"
  • "AWS::SSM::MaintenanceWindowTarget"
  • "AWS::SSM::MaintenanceWindowTask"
  • "AWS::SSM::PatchBaseline"

@Morijarti Morijarti added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases labels Oct 26, 2023
@coveralls
Copy link

coveralls commented Oct 26, 2023 •
edited

Coverage Status

coverage: 82.386% (+0.03%) from 82.361%
when pulling 30b45c5 on feat/cfn_ssm
into 4db402e on master.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited

LocalStack Community integration with Pro

       2 files         2 suites   1h 1m 46s ⏱️
2 332 tests 1 755 ✔️ 577 💤 0 ❌
2 333 runs  1 755 ✔️ 578 💤 0 ❌

Results for commit 30b45c5.

♻️ This comment has been updated with latest results.

@Morijarti
Merge branch 'master' into feat/cfn_ssm
337a095
@Morijarti
Added support for AWS::SSM::MaintenanceWindow resource
a267d9a
@Morijarti
Added two new resources AWS::SSM::MaintenanceWindowTarget and AWS::SS…
a5c6b43 
…M::MaintenanceWindowTask to CloudFormation list in resource_provider.py
@Morijarti
Merge branch 'master' into feat/cfn_ssm
9a7133a 
# Conflicts:
#	localstack/services/cloudformation/engine/quirks.py
#	localstack/services/cloudformation/resource_provider.py
@Morijarti
Added support for AWS::SSM::PatchBaseline resource
7b0fdd9
@Morijarti Morijarti marked this pull request as ready for review October 26, 2023 16:46
pinzon
pinzon approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Morijarti
Merge branch 'master' into feat/cfn_ssm
30b45c5 
# Conflicts:
#	localstack/services/cloudformation/resource_provider.py
@Morijarti Morijarti merged commit a3afc5c into master Nov 8, 2023
27 checks passed
@Morijarti Morijarti deleted the feat/cfn_ssm branch November 8, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

Assignees
No one assigned
Labels
aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Morijarti @coveralls @pinzon