Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit botocore to < 1.31.81 #9586

Merged
merged 1 commit into from Nov 9, 2023
Merged

limit botocore to < 1.31.81 #9586

merged 1 commit into from Nov 9, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 9, 2023

Motivation

With boto/botocore@84c7847#diff-3c03aa9063b20ce7452434106e383aedb840b8b183833425614ca5d3884cc5d0, botocore switched to the JSON protocol for SQS again.
This was already tried with version 1.27.127: boto/botocore@2395012
The last time the changes was reverted.
This PR is just a quick workaround to get the pipeline green before #8268 is over the line.

Changes

  • Limit botocore < 1.31.81

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Nov 9, 2023
@alexrashed alexrashed self-assigned this Nov 9, 2023
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for unblocking the pipeline 🙏

Do we want to get #8268 over the line before the 3.0 release? 🤔

@alexrashed
Copy link
Member Author

Yes, definitely. I am currently looking at it, it should definitely be done before the release. Maybe we can fix it during the day.

Copy link

github-actions bot commented Nov 9, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 2m 23s ⏱️ - 7m 16s
2 332 tests ±0  1 755 ✔️ ±0  577 💤 ±0  0 ±0 
2 333 runs  ±0  1 755 ✔️ ±0  578 💤 ±0  0 ±0 

Results for commit 1018bbd. ± Comparison against base commit 2886dcb.

@alexrashed alexrashed merged commit 05aab11 into master Nov 9, 2023
30 of 31 checks passed
@alexrashed alexrashed deleted the pin-botocore branch November 9, 2023 07:33
@Jecoms
Copy link

Jecoms commented Nov 9, 2023

Will this pin fix be included in a patch release (that could then make its way into the circle orb) or will the patch wait until the full fix is merged?

@alexrashed
Copy link
Member Author

If you are using the boto client from within the localstack docker container, then this is already contained in the latest community image (and will shortly land in the latest pro image). We are about to release a major version next week, there is no patch release planned until then.

However, this does not fix any issues to talk to localstack if your client (outside of localstack) is using the new botocore version.
We are currently working on a fix.
Please take a look at #8267 (which is the issue report for this issue).
You can also follow this PR to get updates on the fix: #8268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants