Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove mount for persistence plugin #9588

Merged
merged 1 commit into from Nov 14, 2023
Merged

remove mount for persistence plugin #9588

merged 1 commit into from Nov 14, 2023

Conversation

giograno
Copy link
Member

@giograno giograno commented Nov 9, 2023

Motivation

We are internalizing the persistence plugin (see 2298).
This step is not needed anymore.

Changes

  • removed the mount of the persistence code.

@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited

LocalStack Community integration with Pro

       2 files         2 suites   1h 27m 3s ⏱️
2 307 tests 2 009 ✔️ 298 💤 0 ❌
2 308 runs  2 009 ✔️ 299 💤 0 ❌

Results for commit 8cbd3fe.

♻️ This comment has been updated with latest results.

@giograno giograno added this to the 3.0 milestone Nov 13, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.006% (-0.003%) from 84.009%
when pulling 8cbd3fe on persistence-plugin
into 78999d0 on master.

@giograno giograno marked this pull request as ready for review November 13, 2023 15:17
alexrashed
alexrashed approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@giograno giograno merged commit 93809ab into master Nov 14, 2023
26 checks passed
@giograno giograno deleted the persistence-plugin branch November 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giograno @coveralls @alexrashed