Organize config list #9654
Merged
Organize config list #9654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the Lambda team. It is supported again and we currently have no alternative. Specifically, `LOCALSTACK_HOST` does not support this scenario (yet).
joe4dev
added
the
semver: patch
joe4dev
requested review from
dominikschubert,
thrau and
HarshCasper
as code owners
joe4dev
requested review from
dominikschubert
and removed request for
dominikschubert
joe4dev
commented
Nov 15, 2023
| @@ -47,8 +47,6 @@ awslocal kinesis list-streams | |||
| } | |||
| ``` | |||
|
|
|||
| **UPDATE**: Use the environment variable `$LOCALSTACK_HOSTNAME` to determine the target host inside your Lambda function. See [Configuration](#configuration) section for more details. | |||
There was a problem hiding this comment.
@HarshCasper Are these outdated READMEs under docs still relevant here. Maybe we should remove them and link to our documentation page instead?
dominikschubert
approved these changes
Nov 15, 2023
| # Note: do *not* include DATA_DIR in this list, as it is treated separately | ||
| # => Synchronize this list with the above and the configuration docs: | ||
| # https://docs.localstack.cloud/references/configuration/ | ||
| # => Sort this list alphabetically |
There was a problem hiding this comment.
good hint! definitely a piece of knowledge that was mostly just lived through tradition but it's good to have this written down here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
localstack.config.pyhas become bloated by mixing up deprecated, removed, and current configurations.HOSTNAME_FROM_LAMBDAis deprecated but still supported.Changes
This PR primarily improves the organization of the config list and removes a deprecation:
HOSTNAME_FROM_LAMBDAfrom deprecations. This was deprecated but then added to the new Lambda provider upon request. The Lambda team decided to un-deprecate it given the need and currently no supported alternatives.AWS_ENDPOINT_URLLOCALSTACK_HOSTNAME