Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to shared pr label enforcers, add bugfix only action #9673

Merged
merged 1 commit into from Nov 17, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 17, 2023

Motivation

We have several repositories where we want to enforce some label constraints on PRs.
This PR migrates these actions to shared workflows in https://github.com/localstack/meta.
These actions are only executed on newly created PRs. The actions will only be triggered if the labels on a PR are changed.
So we still have to watch out for PRs which have already been created!

Changes

  • Switch to shared workflows for:
    • pr-enforce-no-major-master.yml
    • pr-enforce-pr-labels.yml
  • Introduce a new workflow (also using a shared one) to enforce that neither major nor minor labels are on the PR: pr-enforce-no-major-minor-master.yml.

Testing

  • These changes were tested in another private org repo.

TODO

  • After merging these PRs we have to disable the pr-enforce-no-major-master.yml, such that only the pr-enforce-no-major-minor-master.yml is active (which enforces our current restriction on not merging minor changes until we release the next bugfix release).

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Nov 17, 2023
@alexrashed alexrashed self-assigned this Nov 17, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.006% (-0.002%) from 84.008%
when pulling dd0dd5a on use-shared-label-enforcers
into d1e54f4 on master.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschubert dominikschubert merged commit 32a7946 into master Nov 17, 2023
26 checks passed
@dominikschubert dominikschubert deleted the use-shared-label-enforcers branch November 17, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants