Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFN] Support for CF Definition fields #9677

Merged
merged 1 commit into from Nov 27, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Nov 17, 2023

Motivation

This pull request addresses the absence of support for CloudFormation Definition fields in JSON and YAML stack definitions in the current StepFunctions implementation. The proposed changes include support and tests for the four valid combinations: JSON with Definition, JSON with DefinitionString, YAML with Definition, and YAML with DefinitionString.
Closes #5204

Changes

Added support for Definition extraction in StepFunctions's resource_provider, and the 4 relevant tests.

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Nov 17, 2023
@MEPalma MEPalma added this to the 3.1 milestone Nov 17, 2023
@MEPalma MEPalma self-assigned this Nov 17, 2023
Copy link

github-actions bot commented Nov 17, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 5m 10s ⏱️
2 327 tests 2 028 ✔️ 299 💤 0
2 328 runs  2 028 ✔️ 300 💤 0

Results for commit fa7b304.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma force-pushed the MEP-sfn-crate_state_machine_yaml branch from 29b54ad to fa7b304 Compare November 17, 2023 18:00
@coveralls
Copy link

Coverage Status

coverage: 84.011% (+0.008%) from 84.003%
when pulling fa7b304 on MEP-sfn-crate_state_machine_yaml
into 32a7946 on master.

@MEPalma MEPalma added semver: patch Non-breaking changes which can be included in patch releases and removed semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Nov 17, 2023
@MEPalma MEPalma modified the milestones: 3.1, 3.0.1 Nov 24, 2023
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for investigating the YAML support here 👍

@MEPalma MEPalma merged commit 9bb14ea into master Nov 27, 2023
30 checks passed
@MEPalma MEPalma deleted the MEP-sfn-crate_state_machine_yaml branch November 27, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: StateMachine yaml Definition is not supported (DefinitionString works)
3 participants