Introduce DNS_NAME_PATTERNS_TO_RESOLVE_UPSTREAM config #9692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: minor
|
Currently, only patch changes are allowed on master. Your PR labels (semver: minor) indicate that it cannot be merged into the master at this time. |
dfangl
approved these changes
Nov 23, 2023
simonrw
force-pushed
the
dns/rename-dns-local-name-patterns
branch
from
8bea5cd
to
a567acb
Compare
This was referenced Nov 28, 2023
simonrw
force-pushed
the
dns/rename-dns-local-name-patterns
branch
from
a567acb
to
ae1ee60
Compare
simonrw
changed the title
1 task
simonrw
force-pushed
the
dns/rename-dns-local-name-patterns
branch
from
ae1ee60
to
e611a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we may wish to skip resolving a DNS name with the LocalStack DNS server. For example, when using transparent endpoint injection some AWS URLs need to resolve to addresses on the public internet in order to e.g. fetch something from an S3 bucket.
We currently support this feature with the configuration variable
DNS_LOCAL_NAME_PATTERNS, but this name sounds like it does the opposite -> "local name patterns" sounds like it will either:This is not the case.
Changes
We cannot remove this configuration variable since it is a breaking change, and we have not introduced a deprecation phase. This PR starts the deprecation phase of
DNS_LOCAL_NAME_PATTERNS, and instead lets the user configureDNS_NAME_PATTERNS_TO_RESOLVE_UPSTREAM. Currently during this deprecation phase, we accept both variables, however in the futureDNS_LOCAL_NAME_PATTERNSwill not be used to configure DNS resolution.TODO