Fix for double-slash uri request #9723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
thrau
reviewed
Nov 24, 2023
calvernaz
added
the
semver: patch
calvernaz
force-pushed
the
8170-bug-apigateway-v2-httpapi-does-not-handle-trailing-slashes-and-raises-authorizer-exception
branch
from
8890c50
to
f01cdf9
Compare
bentsku
approved these changes
Nov 27, 2023
calvernaz
force-pushed
the
8170-bug-apigateway-v2-httpapi-does-not-handle-trailing-slashes-and-raises-authorizer-exception
branch
from
47f0e7c
to
7f78fc6
Compare
calvernaz
force-pushed
the
8170-bug-apigateway-v2-httpapi-does-not-handle-trailing-slashes-and-raises-authorizer-exception
branch
from
7f78fc6
to
8b6b226
Compare
calvernaz
deleted the
8170-bug-apigateway-v2-httpapi-does-not-handle-trailing-slashes-and-raises-authorizer-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The RAW_URI can contain a path with a double slash for example, for the request
https://28e9f096.execute-api.localhost.localstack.cloud:4566//hello, RAW_URI will be//hello.This will cause an issue parsing the url using the function
urlparse. With this fix, we replace//with/to proceed with the parsing.Changes
Normalizes the RAW_URI by replacing the
//with/. It does it in two places, on thehttppackage and on the apigatewayrouter_asf.Testing
Unit tests for the specific parsing function.