Enable AppSync cloudformation resources #9726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
simonrw
force-pushed
the
cfn/appsync-resources
branch
from
a505ecf
to
915501e
Compare
simonrw
force-pushed
the
cfn/appsync-resources
branch
from
915501e
to
ff7370f
Compare
simonrw
force-pushed
the
cfn/appsync-resources
branch
3 times, most recently
from
5c94d95
to
f125d38
Compare
simonrw
force-pushed
the
cfn/appsync-resources
branch
from
f125d38
to
72334e4
Compare
simonrw
changed the title
Morijarti
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For a little while now our CloudFormation AppSync implementation has not supported JS functions. In particular, we do not propagate the
Codefield, meaning that resolvers using JS functions do not have their mapping JS executed. This is the incorrect behaviour. We migrated the resources to the new Resource Provider API in the private repo, and this change enables their use.Changes