[SFN] Fix optimised integrations clients leading to timeouts and retries #9732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: patch
dominikschubert
approved these changes
Nov 27, 2023
|
Many thanks @MEPalma and @dominikschubert. Localstack is a crazy ambitious project, and releasing a rewrite of stepfunctions (of all things) is super ambitious again. Thanks for being so responsive and getting these fixes out so fast. I see 3 SFN PRs up and approved this morning, well done 👏 . Hopefully all the regressions are caught soon and you're back to normal operating procedures soon! We're loving using localstack, keep up the great work! |
|
Hey @MEPalma and/or @dominikschubert : Any idea when this change will make it to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Invocations of service integrations in SFN v2 currently trigger the default behaviour of boto for connection and read timeouts, as well as the retry strategy. This could potentially disrupt the State Machine's behaviour related to timeout and retry declarations.
Closes #9731
Changes
This pull request deactivates the mentioned boto behaviour to guarantee that timeout issues are passed upstream to the interpreter as intended.