Enable test for Fn::GetAZs and extend feature #9740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzon
added
the
semver: patch
dominikschubert
approved these changes
Nov 28, 2023
Comment on lines
+240
to
+243
| TODO parametrize this test. | ||
| For that we need to be able to parametrize the client region. The docs show the we should be | ||
| able to put any region in the parameters but it doesn't work. It only accepts the same region from the client config | ||
| if you put anything else it just returns an empty list. |
There was a problem hiding this comment.
👍
I think it's fine for now since we usually assume us-east-1 anyway, i.e. we don't currently handle region specific idiosyncrasies and treat everything as if it were us-east-1, which has the broadest support out of all regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This CFn function was requested in #9534 but it seems that @viren-nadkarni already developed the feature while working on the Multi-Region support.
Changes
I extended the amount of AZs the function returns to match the amount AWS returns for
us-east-1Testing
I un-skipped the preexisting test of this feature and added a snapshot