[SFN] Enhancements for Intrinsic Function StringSplit #9749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: patch
dominikschubert
approved these changes
Nov 28, 2023
...pfunctions/asl/component/intrinsic/function/statesfunction/string_operations/string_split.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the current implementation of the SFN interpreter, the Intrinsic Functions States.StringSplit does not filter for non-empty strings after computing the parts. This PR addresses such behaviour by filtering for empty string results.
Closes: #9742
Changes
Added empty string filtering after computing the split parts in the implementation for States.StringSplit, and a number of relevant test cases