Fix SQS CFn updates with no change #9831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
simonrw
force-pushed
the
fix/cfn/sqs-update
branch
2 times, most recently
from
f6d395f
to
5dfb519
Compare
simonrw
force-pushed
the
fix/cfn/sqs-update
branch
from
5dfb519
to
5c8f143
Compare
simonrw
commented
Dec 11, 2023
Comment on lines
189
to
195
| should_replace = ( | ||
| request.desired_state.get("QueueName", request.previous_state["QueueName"]) | ||
| != request.previous_state["QueueName"] | ||
| ) or ( | ||
| request.desired_state.get("FifoQueue", request.previous_state["FifoQueue"]) | ||
| != request.previous_state["FifoQueue"] | ||
| ) |
There was a problem hiding this comment.
@dominikschubert there must be a way to automate this sort of detection from the spec... 🤔
simonrw
requested review from
thrau,
baermat,
dominikschubert and
pinzon
as code owners
simonrw
requested review from
bentsku
and removed request for
pinzon and
baermat
thrau
reviewed
Dec 12, 2023
Comment on lines
+813
to
+814
| # this is an issue with our update detection. We should never be in this state. | ||
| request.action = "Add" |
There was a problem hiding this comment.
so is this a TODO for the framework? or what do we do about the comment?
There was a problem hiding this comment.
This is an issue with the CFn engine in LocalStack. We should never try to perform an update/modify on a resource that has no previous state, since this means the resource has not been created yet.
There was a problem hiding this comment.
I think it's fine as a fix for now until the update detection is fixed
thrau
approved these changes
Dec 12, 2023
bentsku
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a CFn stack containing an SQS queue is updated, but the SQS queue is not changed, we trigger invalid behaviour where we assume information in the incoming request that is not present. Specifically, we try to get the queue name from the incoming state, and if this was not specified in the first place (i.e. we rely on auto-generating the queue name) the stack fails to update.
While investigating this issue I found another issue when adding a completely new resource. The "update" method is still invoked, but because we raise a
NotImplementedErrorwe try to handle this in the executor, but this assumes there is a previous state. For a completely new resource, this is not the case.Closes #9826
Changes