fix: serverless failing multi-account/region tests #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sannya-singal
added
the
semver: patch
sannya-singal
force-pushed
the
serverless_multi_acc
branch
from
a7b96f6
to
c5f55e4
Compare
sannya-singal
commented
Dec 12, 2023
viren-nadkarni
approved these changes
Dec 12, 2023
tests/aws/test_serverless.py
Outdated
| run( | ||
| ["npm", "run", "deploy", "--", f"--region={TEST_AWS_REGION_NAME}"], | ||
| cwd=base_dir, | ||
| env_vars={"AWS_ACCESS_KEY_ID": TEST_AWS_ACCOUNT_ID}, |
There was a problem hiding this comment.
Non-blocking: Is it possible to use the TEST_AWS_ACCESS_KEY_ID var here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using values other than
000000000000for account ID orus-east-1for region,serverlesstests should still create the consequent resources in these accounts and region. When we try to deploy the serverless setup using non-default region value in tests it throwsIndexErrororAssertionErrorsince the setup wasn't getting deployed in the correct account.Changes
This PR:
AWS_ACCESS_KEY_IDas an environment variable toserverless-localstack.AWS_PROFILEenv variable.sqs_queue_url_for_arn.logs_clientinget_lambda_log_events.Testing
The tests were failing previously when executed with a non-default account ID, set through environment variables (
TEST_AWS_ACCOUNT_ID=111111111111,TEST_AWS_ACCESS_KEY_ID=111111111111,TEST_AWS_REGION=us-west-1). This PR fixes:tests.aws.test_serverless.TestServerless.test_event_rules_deployedtests.aws.test_serverless.TestServerless.test_dynamodb_stream_handler_deployedtests.aws.test_serverless.TestServerless.test_kinesis_stream_handler_deployedtests.aws.test_serverless.TestServerless.test_queue_handler_deployedtests.aws.test_serverless.TestServerless.test_lambda_with_configs_deployedtests.aws.test_serverless.TestServerless.test_apigateway_deployed