Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix S3 lifecycle tags filter #9859

Merged
merged 1 commit into from Dec 13, 2023
Merged

fix S3 lifecycle tags filter #9859

merged 1 commit into from Dec 13, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Dec 12, 2023 •
edited

Motivation

As reported in #9857, we have an issue with S3 lifecycle configuration and tag filters when the object does not have tags.

Changes

  • add a proper check when applying lifecycle configuration if the object tags are not None before trying to get attributes from it

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels Dec 12, 2023
@bentsku bentsku self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

    2 files      2 suites   3m 7s ⏱️
377 tests 327 ✔️   50 💤 0 ❌
754 runs  654 ✔️ 100 💤 0 ❌

Results for commit a290fe7.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 10m 6s ⏱️
2 400 tests 2 172 ✔️ 228 💤 0 ❌
2 401 runs  2 172 ✔️ 229 💤 0 ❌

Results for commit a290fe7.

@bentsku bentsku marked this pull request as ready for review December 12, 2023 21:20
macnev2013
macnev2013 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. LGTM 🚀

@bentsku bentsku merged commit a77e4f8 into master Dec 13, 2023
41 checks passed
@bentsku bentsku deleted the fix-s3-lifecycle-tags branch December 13, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macnev2013 macnev2013 macnev2013 approved these changes

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bentsku @macnev2013