Add flag to disable kinesis-mock persistence #9871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With recent kinesis performance tests, we have seen a significant performance degradation up to an out-of-memory error of kinesis-mock, especially when pushing over 50 entries with the maximum payload of 1024KB to a stream.
This behavior is way worse when the persistence is enabled when starting kinesis-mock. For now, to fix it for users not needing persistence, we need a flag to disable it.
In the future, we need to spend some work on increasing the performance and memory usage of the persistence of our kinesis implementation.
Changes