New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcribe: Add support for transcribing video files #9898
Conversation
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 10m 52s ⏱️ -48s Results for commit da3d1c8. ± Comparison against base commit dd9b2b0. This pull request removes 6 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
("../../files/en-gb.mp4", "hello my name is"), | ||
("../../files/en-gb.ogg", "hello my name is"), | ||
("../../files/en-gb.webm", "hello my name is"), | ||
("../../files/en-us_video.mkv", "one of the most vital"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a test case for mp4
video file, as stated in the github issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in da3d1c8
Just a minor nit for adding a |
Motivation
This PR adds support for files with video streams to Transcribe. The list of supported media files remain the same. Like before, only the audio stream matters to Transcribe but now it differentiates the streams better for metadata extraction.
Tests
Updates existing
test_transcribe_supported_media_formats
to add new parameters with video file and its expected speech content. Confirmed passing.The new media files are of different container formats: mkv and mp4, however the underlying audio stream codec is same: aac.
Related
Closes: #9812