Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sqs message group visibility when sending messages #9975

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

thrau
Copy link
Member

@thrau thrau commented Jan 3, 2024

Motivation

Even after the initial implementation of FIFO message groups in #8238, users have reported odd behavior when using SQS FIFO queues related to message group visibility specifically that consumers are triggered although the message group is expected to be invisible #8724. This also affected lambdas triggered with fifo queues #7036.

This PR fixes the mechanism we were using to reset message group visibility, which was too general. It assumed that every message put into the message group reset its visibility, when really it should just be messages that were previously invisible, not new ones.

Changes

  • message group visibility is no longer reset when new messages are sent to the queue

Fixes

@thrau thrau requested a review from baermat as a code owner January 3, 2024 01:18
@thrau thrau added the semver: patch Non-breaking changes which can be included in patch releases label Jan 3, 2024
@thrau thrau linked an issue Jan 3, 2024 that may be closed by this pull request
1 task
@coveralls
Copy link

Coverage Status

coverage: 84.014% (+0.004%) from 84.01%
when pulling c345516 on fix-sqs-fifo-message-group
into 4a5a9fd on master.

Copy link

github-actions bot commented Jan 3, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 13m 51s ⏱️
2 428 tests 2 202 ✅ 226 💤 0 ❌
2 429 runs  2 202 ✅ 227 💤 0 ❌

Results for commit c345516.

Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thrau thrau merged commit 367ff33 into master Jan 3, 2024
31 checks passed
@thrau thrau deleted the fix-sqs-fifo-message-group branch January 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Incorrect behavior of receive message in sqs fifo queue with same group ID
3 participants