Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lambda alarm action for cloudwatch #9985

Merged
merged 1 commit into from Jan 4, 2024
Merged

add lambda alarm action for cloudwatch #9985

merged 1 commit into from Jan 4, 2024

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented Jan 3, 2024

Motivation

AWS recently added support for AWS Lambda as an alarm state action.
This PR enables Lambda targets for alarm actions on LocalStack.

Changes

  • added snapshot test, that triggers a lambda on state ALARM
  • implemented the lambda invocation for LS

@steffyP steffyP added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jan 3, 2024
@steffyP steffyP mentioned this pull request Jan 3, 2024
Merged
11 tasks
@coveralls
Copy link

Coverage Status

coverage: 84.05% (+0.03%) from 84.022%
when pulling dd9a733 on alarm-dst-lambda
into 7548ba6 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 16m 30s ⏱️
2 431 tests 2 205 ✅ 226 💤 0 ❌
2 432 runs  2 205 ✅ 227 💤 0 ❌

Results for commit dd9a733.

@steffyP steffyP marked this pull request as ready for review January 4, 2024 08:36
@steffyP steffyP requested a review from baermat January 4, 2024 08:40
@steffyP
Copy link
Member Author

steffyP commented Jan 4, 2024

pinging the lambda service owner to keep you in the loop
/cc @joe4dev @dfangl

baermat
baermat approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented a week after AWS' announcement right before christmas 🥳 LGTM! I think it's ok to leave the metric_data_query test for now

@steffyP steffyP merged commit 60b5ea1 into master Jan 4, 2024
28 of 29 checks passed
@steffyP steffyP deleted the alarm-dst-lambda branch January 4, 2024 17:43
@baermat baermat mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baermat baermat baermat approved these changes

@silv-io silv-io Awaiting requested review from silv-io

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@steffyP @coveralls @baermat