fix CopySource unquoting of special + char #9992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported with #9990, we had an issue when copying a file with a space in the name with Go. This issue was not present with Python however. When looking at the sample provided by the user, it appeared that Go in URL encoding space character with
+
when Python is using%20
.When calling
unquote
with Python, it won't replace an encoded URL+
character with a space. We will need to manually replace it before unquote the URL to not accidentally replaced an encoded+
.Changes
Manually replace an encoded URL
+
when parsing theCopySource
header.Added 2 different AWS tests to verify exactly the fix:
%20
so we couldn't reproduce exactly the issue. This test fails without the fix, confirming it. This specific test isxfail
for the v2 legacy provider as moto does not handle this edge case (so not a regression from the new provider)fixes #9990