use Distribution object to resolve packages #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous package finding mechanism wasn't resolving namespace packages correctly. There is a special
PEP420PackageFinder
that we could use, but while investigating, I noticed that the setuptoolsDistribution
object already resolves packages correctly based on thetool.setuptools.package.find
config in either the setup.cfg or pyproject.toml. Using this instead instead ofsetuptools.find_package
directly this also solves the outstanding issue of correctly passingwhere
,exclude
, andinclude
parameters to the finder.We still require the source path (
where
) to load all modules, code which we already introduced in #17.Changes
Distribution
object instead of callingsetuptools.find_package
manually.