Refactor code #17
Merged
Refactor code #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakkeger
force-pushed
the
refactor_default_action
branch
24 times, most recently
from
a3538ea
to
3faad6b
Compare
|
⚡️ Running CI build with LocalStack ... |
lakkeger
force-pushed
the
refactor_default_action
branch
5 times, most recently
from
c220895
to
31d526e
Compare
lakkeger
force-pushed
the
refactor_default_action
branch
2 times, most recently
from
b157dcb
to
bb050f6
Compare
lakkeger
force-pushed
the
refactor_default_action
branch
from
bb050f6
to
f046bca
Compare
lakkeger
force-pushed
the
refactor_default_action
branch
2 times, most recently
from
958c786
to
01d91d7
Compare
…-localstack into refactor_default_action
lakkeger
force-pushed
the
refactor_default_action
branch
from
01d91d7
to
9b85434
Compare
HarshCasper
approved these changes
May 27, 2024
lukqw
approved these changes
May 29, 2024
There was a problem hiding this comment.
This looks great! Thanks for getting ahold of this change @lakkeger!
As teased in a couple of places I'd like to move away from the notion of preview in the future, and replace the term with ephemeral.
Might be something we can tackle before releasing 0.2.0, but lets talk offline.
lakkeger
force-pushed
the
refactor_default_action
branch
from
d634afc
to
1d489c9
Compare
lakkeger
force-pushed
the
refactor_default_action
branch
from
1d489c9
to
5b47bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Motivation
Our custom action needs some love in the form of refactor into a modular setup for better maintainability and separation of modules. The vision would be a dynamic setup and proxying through most options via the main action.
Changes