Add shutdown ephemeral instance action + test #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ephemeral instance for the application preview has been shut down |
lukqw
force-pushed
the
add-shutdown-ephemeral
branch
from
a81fd13
to
6389536
Compare
lukqw
force-pushed
the
add-shutdown-ephemeral
branch
from
d18e128
to
0f258dc
Compare
lukqw
force-pushed
the
add-shutdown-ephemeral
branch
from
6095393
to
f4a13ad
Compare
lukqw
force-pushed
the
add-shutdown-ephemeral
branch
from
0a8961c
to
a8f191c
Compare
lakkeger
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds a new action to shutdown ephemeral instance to our suite of actions.
It further adds a small test suite that checks the flow of starting / stopping an ephemeral instance.
Honorable mentions
This PR copies parts of #12 for which I want to give kudos to @Pive01!
Future work
I plan to move the
previewaction to theephemeraldirectory and rename it tostart.Further I'd like to get rid of the data exchange based on artifacts, and switch to either proper inputs/outputs or env var based data passing.