revamp the action for localstack authorship #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
May 27, 2023
README.md
Outdated
| @@ -48,7 +48,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
|
|
|||
| - name: Start LocalStack | |||
| uses: HarshCasper/setup-localstack@v0.1.2 | |||
| uses: LocalStack/setup-localstack@v0.1.2 | |||
There was a problem hiding this comment.
nit: could be updated to v0.1.3, for consistency with the version above
Suggested change
| uses: LocalStack/setup-localstack@v0.1.2 | |
| uses: LocalStack/setup-localstack@v0.1.3 |
There was a problem hiding this comment.
In general, how do you feel about introducing a latest tag for this action @HarshCasper ? It would require a bit of additional effort every time we release a new version (tagging the latest release commit with the git tag latest), but then users could simply refer to this in their pipelines:
uses: LocalStack/setup-localstack@latest
Might come in handy, especially if we anticipate that there will be more updates coming for this Action in the near future.. 👍
There was a problem hiding this comment.
Let me see how to set it up 👍
I will do this in a follow-up PR
whummer
reviewed
May 27, 2023
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.