Implementing a Deployment solution for AWS #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should simplify the deployment toward AWS a lot, as now with this PR they simply need to set 2 env vars and cdk deploy to get a fully working deployment. This also entirely rely on the upstream docker image you guys provide without special modification |
|
I see that only port 443 -> 80 mapping is being setup in the LB <-> ECS container. How does it properly setup the TCP ports for the websocket port range (1024 - 65535)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Deployment using Cloud Development Kit with Amazon Web Services. all code is tested locally.
if you are interested in testing it, feel free to run it following the instruction in deploy/aws/README.md