-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEOMESA-2284 Remove deprecated functionality #2470
GEOMESA-2284 Remove deprecated functionality #2470
Conversation
* Remove modules: * geomesa-accumulo/geomesa-accumulo-compute * geomesa-accumulo/geomesa-accumulo-security * geomesa-accumulo/geomesa-accumulo-stats-gs-plugin * geomesa-convert/geomesa-convert-scripting * geomesa-convert/geomesa-convert-simplefeature * geomesa-metrics * geomesa-web/geomesa-web-data * Remove classes: * org.locationtech.geomesa.accumulo.AccumuloQueryProperties * org.locationtech.geomesa.accumulo.util.AccumuloSftBuilder * org.locationtech.geomesa.accumulo.util.BoundingBoxUtil * org.locationtech.geomesa.jobs.accumulo.export.ExportFeaturesJob * org.locationtech.geomesa.convert.package * org.locationtech.geomesa.convert.SimpleFeatureConverters * org.locationtech.geomesa.convert.SimpleFeatureConverterFactory * org.locationtech.geomesa.convert.Transformers * org.locationtech.geomesa.convert.CompositeConverterFactory * org.locationtech.geomesa.features.avro.AvroFeatureDeserializer * org.locationtech.geomesa.index.stats.MetadataBackedStats.RunnableStats * org.locationtech.geomesa.index.stats.MetadataBackedStats.UnoptimizedRunnableStats * org.locationtech.geomesa.process.GeoMesaProcessVisitor * org.locationtech.geomesa.utils.cache.SoftThreadLocalCache * org.locationtech.geomesa.utils.geometry.Geometry * org.locationtech.geomesa.utils.geotools.SftBuilder * Remove methods: * org.locationtech.geomesa.convert.EvaluationContext#counter * org.locationtech.geomesa.convert.EvaluationContext#getCache * org.locationtech.geomesa.convert.EvaluationContext#apply(IndexedSeq[String], Array[Any], Counter, Map[String, EnrichmentCache]) * org.locationtech.geomesa.convert2.SimpleFeatureConverterFactory#infer(InputStream, Option[SimpleFeatureType]) * org.locationtech.geomesa.features.avro.serde.ASFDeserializer#setString,#setInt,etc * org.locationtech.geomesa.features.ScalaSimpleFeature(String, SimpleFeatureType) * org.locationtech.geomesa.features.ScalaSimpleFeature#create * org.locationtech.geomesa.features.kryo.KryoFeatureSerializer#VERSION * org.locationtech.geomesa.filter.FilterHelper#visitBinarySpatialOp * org.locationtech.geomesa.filter.FilterHelper#metersMultiplier * org.locationtech.geomesa.filter#partitionIndexedAttributes * org.locationtech.geomesa.filter#attrIndexed * org.locationtech.geomesa.filter#isIndexedAttributeFilter * org.locationtech.geomesa.index.api.GeoMesaFeatureIndex#formatTableName,#formatSoloTableName,#formatSharedTableName,#tableSuffix,#concatenate,#hexEncodeNonAlphaNumeric * org.locationtech.geomesa.index.geotools.GeoMesaDataStore#getDistributeVersion,#getVersion * org.locationtech.geomesa.index.metadata.GeoMesaMetadata#ATTRIBUTES_KEY,#VERSION_KEY,#STATS_GENERATION_KEY,#STATS_INTERVAL_KEY * org.locationtech.geomesa.index.stats.GeoMesaStats#generateStats,#statUpdater,#clearStats,#rename,#getAttributeBounds,#runStats,#getStats * org.locationtech.geomesa.index.strategies.SpatioTemporalFilterStrategy#isBounded * org.locationtech.geomesa.memory.cqengine.GeoCQEngine#add,#addAll,#remove,#getById,#getReaderForFilter * org.locationtech.geomesa.utils.geotools.RichSimpleFeatureType.RichSimpleFeatureType#setIndexCoverage,#getIndexCoverage,#setBinTrackId,#isBinTrackId,#isIndexed,#getDtgDescriptor,#getStIndexSchema,#setStIndexSchema,#getBinTrackId,#setTableSharing,#setTableSharingPrefix,#getTableSplitter,#getTableSplitterOptions,#setRemoteVersion * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes.Configs various * org.locationtech.geomesa.utils.geotools.sft.SimpleFeatureSpecConfig#normalizeKey * org.locationtech.geomesa.utils.index.SpatialIndex#insert,#remove,#get,#query * org.locationtech.geomesa.utils.stats.DescriptiveStats#attributes * org.locationtech.geomesa.utils.stats.EnumerationStat#attribute * org.locationtech.geomesa.utils.stats.Frequency#attribute,#dtgIndex * org.locationtech.geomesa.utils.stats.GroupBy#attribute,#exampleStat * org.locationtech.geomesa.utils.stats.Histogram#attribute * org.locationtech.geomesa.utils.stats.MinMax#attribute * org.locationtech.geomesa.utils.stats.TopK#attribute * org.locationtech.geomesa.utils.stats.Z3Frequency#geomIndex,#dtgIndex * org.locationtech.geomesa.utils.stats.Z3Histogram#geomIndex,#dtgIndex Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com>
@@ -81,17 +86,17 @@ class EnrichmentCacheTest extends Specification { | |||
| } | |||
| } | |||
| fields = [ | |||
| { name = "id", transform = "toString($0)" } | |||
| { name = "id", transform = "toString($1)" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this shift between $0 and $1 something that is documented well?
Is there anything we can do to help folks update their existing converters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just b/c i switched the converter used in this test from a 'test' implementation that was 0-based to the regular delimited-text converter, which is 1-based. this doesn't reflect any change in functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about helping people upgrade existing converters...
* geomesa-spark/geomesa-spark-geotools * Additional classes: * org.locationtech.geomesa.index.conf.DigitSplitter * org.locationtech.geomesa.index.conf.NoSplitter * org.locationtech.geomesa.index.conf.AlphaNumericSplitter * org.locationtech.geomesa.index.conf.HexSplitter * org.locationtech.geomesa.spark.jts.util.GeoJSONExtensions * Additional methods: * org.locationtech.geomesa.accumulo.AccumuloVersion#ensureTableExists * org.locationtech.geomesa.accumulo.AccumuloVersion#ensureNamespaceExists * org.locationtech.geomesa.accumulo.data.AccumuloDataStore#DeprecatedSchemaVersionKey * org.locationtech.geomesa.accumulo.data.AccumuloDataStore#tableOps * org.locationtech.geomesa.accumulo.data.AccumuloDataStoreFactory#DISPLAY_NAME * org.locationtech.geomesa.accumulo.data.AccumuloDataStoreFactory#DESCRIPTION * org.locationtech.geomesa.accumulo.util.AccumuloSchemaBuilder.AccumuloUserDataBuilder#tableSharing * org.locationtech.geomesa.fs.storage.common.StorageKeys#PartitionSchemeKey * org.locationtech.geomesa.jobs.mapreduce.GeoMesaOutputFormat#configureDataStore * org.locationtech.geomesa.spark.GeoMesaDataSource#structType2SFT * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes.AttributeOptions various * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes#getSecondaryIndexedAttributes * org.locationtech.geomesa.utils.index.SpatialIndex#getCenter Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com>
* GEOMESA-2284 Remove deprecated functionality * Remove modules: * geomesa-accumulo/geomesa-accumulo-compute * geomesa-accumulo/geomesa-accumulo-security * geomesa-accumulo/geomesa-accumulo-stats-gs-plugin * geomesa-convert/geomesa-convert-scripting * geomesa-convert/geomesa-convert-simplefeature * geomesa-metrics * geomesa-web/geomesa-web-data * Remove classes: * org.locationtech.geomesa.accumulo.AccumuloQueryProperties * org.locationtech.geomesa.accumulo.util.AccumuloSftBuilder * org.locationtech.geomesa.accumulo.util.BoundingBoxUtil * org.locationtech.geomesa.jobs.accumulo.export.ExportFeaturesJob * org.locationtech.geomesa.convert.package * org.locationtech.geomesa.convert.SimpleFeatureConverters * org.locationtech.geomesa.convert.SimpleFeatureConverterFactory * org.locationtech.geomesa.convert.Transformers * org.locationtech.geomesa.convert.CompositeConverterFactory * org.locationtech.geomesa.features.avro.AvroFeatureDeserializer * org.locationtech.geomesa.index.stats.MetadataBackedStats.RunnableStats * org.locationtech.geomesa.index.stats.MetadataBackedStats.UnoptimizedRunnableStats * org.locationtech.geomesa.process.GeoMesaProcessVisitor * org.locationtech.geomesa.utils.cache.SoftThreadLocalCache * org.locationtech.geomesa.utils.geometry.Geometry * org.locationtech.geomesa.utils.geotools.SftBuilder * Remove methods: * org.locationtech.geomesa.convert.EvaluationContext#counter * org.locationtech.geomesa.convert.EvaluationContext#getCache * org.locationtech.geomesa.convert.EvaluationContext#apply(IndexedSeq[String], Array[Any], Counter, Map[String, EnrichmentCache]) * org.locationtech.geomesa.convert2.SimpleFeatureConverterFactory#infer(InputStream, Option[SimpleFeatureType]) * org.locationtech.geomesa.features.avro.serde.ASFDeserializer#setString,#setInt,etc * org.locationtech.geomesa.features.ScalaSimpleFeature(String, SimpleFeatureType) * org.locationtech.geomesa.features.ScalaSimpleFeature#create * org.locationtech.geomesa.features.kryo.KryoFeatureSerializer#VERSION * org.locationtech.geomesa.filter.FilterHelper#visitBinarySpatialOp * org.locationtech.geomesa.filter.FilterHelper#metersMultiplier * org.locationtech.geomesa.filter#partitionIndexedAttributes * org.locationtech.geomesa.filter#attrIndexed * org.locationtech.geomesa.filter#isIndexedAttributeFilter * org.locationtech.geomesa.index.api.GeoMesaFeatureIndex#formatTableName,#formatSoloTableName,#formatSharedTableName,#tableSuffix,#concatenate,#hexEncodeNonAlphaNumeric * org.locationtech.geomesa.index.geotools.GeoMesaDataStore#getDistributeVersion,#getVersion * org.locationtech.geomesa.index.metadata.GeoMesaMetadata#ATTRIBUTES_KEY,#VERSION_KEY,#STATS_GENERATION_KEY,#STATS_INTERVAL_KEY * org.locationtech.geomesa.index.stats.GeoMesaStats#generateStats,#statUpdater,#clearStats,#rename,#getAttributeBounds,#runStats,#getStats * org.locationtech.geomesa.index.strategies.SpatioTemporalFilterStrategy#isBounded * org.locationtech.geomesa.memory.cqengine.GeoCQEngine#add,#addAll,#remove,#getById,#getReaderForFilter * org.locationtech.geomesa.utils.geotools.RichSimpleFeatureType.RichSimpleFeatureType#setIndexCoverage,#getIndexCoverage,#setBinTrackId,#isBinTrackId,#isIndexed,#getDtgDescriptor,#getStIndexSchema,#setStIndexSchema,#getBinTrackId,#setTableSharing,#setTableSharingPrefix,#getTableSplitter,#getTableSplitterOptions,#setRemoteVersion * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes.Configs various * org.locationtech.geomesa.utils.geotools.sft.SimpleFeatureSpecConfig#normalizeKey * org.locationtech.geomesa.utils.index.SpatialIndex#insert,#remove,#get,#query * org.locationtech.geomesa.utils.stats.DescriptiveStats#attributes * org.locationtech.geomesa.utils.stats.EnumerationStat#attribute * org.locationtech.geomesa.utils.stats.Frequency#attribute,#dtgIndex * org.locationtech.geomesa.utils.stats.GroupBy#attribute,#exampleStat * org.locationtech.geomesa.utils.stats.Histogram#attribute * org.locationtech.geomesa.utils.stats.MinMax#attribute * org.locationtech.geomesa.utils.stats.TopK#attribute * org.locationtech.geomesa.utils.stats.Z3Frequency#geomIndex,#dtgIndex * org.locationtech.geomesa.utils.stats.Z3Histogram#geomIndex,#dtgIndex Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com> * * Additional modules: * geomesa-spark/geomesa-spark-geotools * Additional classes: * org.locationtech.geomesa.index.conf.DigitSplitter * org.locationtech.geomesa.index.conf.NoSplitter * org.locationtech.geomesa.index.conf.AlphaNumericSplitter * org.locationtech.geomesa.index.conf.HexSplitter * org.locationtech.geomesa.spark.jts.util.GeoJSONExtensions * Additional methods: * org.locationtech.geomesa.accumulo.AccumuloVersion#ensureTableExists * org.locationtech.geomesa.accumulo.AccumuloVersion#ensureNamespaceExists * org.locationtech.geomesa.accumulo.data.AccumuloDataStore#DeprecatedSchemaVersionKey * org.locationtech.geomesa.accumulo.data.AccumuloDataStore#tableOps * org.locationtech.geomesa.accumulo.data.AccumuloDataStoreFactory#DISPLAY_NAME * org.locationtech.geomesa.accumulo.data.AccumuloDataStoreFactory#DESCRIPTION * org.locationtech.geomesa.accumulo.util.AccumuloSchemaBuilder.AccumuloUserDataBuilder#tableSharing * org.locationtech.geomesa.fs.storage.common.StorageKeys#PartitionSchemeKey * org.locationtech.geomesa.jobs.mapreduce.GeoMesaOutputFormat#configureDataStore * org.locationtech.geomesa.spark.GeoMesaDataSource#structType2SFT * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes.AttributeOptions various * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes#getSecondaryIndexedAttributes * org.locationtech.geomesa.utils.index.SpatialIndex#getCenter Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com> * Adding raster and native api removal to upgrade guide
* GEOMESA-2284 Remove deprecated functionality * Remove modules: * geomesa-accumulo/geomesa-accumulo-compute * geomesa-accumulo/geomesa-accumulo-security * geomesa-accumulo/geomesa-accumulo-stats-gs-plugin * geomesa-convert/geomesa-convert-scripting * geomesa-convert/geomesa-convert-simplefeature * geomesa-metrics * geomesa-web/geomesa-web-data * Remove classes: * org.locationtech.geomesa.accumulo.AccumuloQueryProperties * org.locationtech.geomesa.accumulo.util.AccumuloSftBuilder * org.locationtech.geomesa.accumulo.util.BoundingBoxUtil * org.locationtech.geomesa.jobs.accumulo.export.ExportFeaturesJob * org.locationtech.geomesa.convert.package * org.locationtech.geomesa.convert.SimpleFeatureConverters * org.locationtech.geomesa.convert.SimpleFeatureConverterFactory * org.locationtech.geomesa.convert.Transformers * org.locationtech.geomesa.convert.CompositeConverterFactory * org.locationtech.geomesa.features.avro.AvroFeatureDeserializer * org.locationtech.geomesa.index.stats.MetadataBackedStats.RunnableStats * org.locationtech.geomesa.index.stats.MetadataBackedStats.UnoptimizedRunnableStats * org.locationtech.geomesa.process.GeoMesaProcessVisitor * org.locationtech.geomesa.utils.cache.SoftThreadLocalCache * org.locationtech.geomesa.utils.geometry.Geometry * org.locationtech.geomesa.utils.geotools.SftBuilder * Remove methods: * org.locationtech.geomesa.convert.EvaluationContext#counter * org.locationtech.geomesa.convert.EvaluationContext#getCache * org.locationtech.geomesa.convert.EvaluationContext#apply(IndexedSeq[String], Array[Any], Counter, Map[String, EnrichmentCache]) * org.locationtech.geomesa.convert2.SimpleFeatureConverterFactory#infer(InputStream, Option[SimpleFeatureType]) * org.locationtech.geomesa.features.avro.serde.ASFDeserializer#setString,#setInt,etc * org.locationtech.geomesa.features.ScalaSimpleFeature(String, SimpleFeatureType) * org.locationtech.geomesa.features.ScalaSimpleFeature#create * org.locationtech.geomesa.features.kryo.KryoFeatureSerializer#VERSION * org.locationtech.geomesa.filter.FilterHelper#visitBinarySpatialOp * org.locationtech.geomesa.filter.FilterHelper#metersMultiplier * org.locationtech.geomesa.filter#partitionIndexedAttributes * org.locationtech.geomesa.filter#attrIndexed * org.locationtech.geomesa.filter#isIndexedAttributeFilter * org.locationtech.geomesa.index.api.GeoMesaFeatureIndex#formatTableName,#formatSoloTableName,#formatSharedTableName,#tableSuffix,#concatenate,#hexEncodeNonAlphaNumeric * org.locationtech.geomesa.index.geotools.GeoMesaDataStore#getDistributeVersion,#getVersion * org.locationtech.geomesa.index.metadata.GeoMesaMetadata#ATTRIBUTES_KEY,#VERSION_KEY,#STATS_GENERATION_KEY,#STATS_INTERVAL_KEY * org.locationtech.geomesa.index.stats.GeoMesaStats#generateStats,#statUpdater,#clearStats,#rename,#getAttributeBounds,#runStats,#getStats * org.locationtech.geomesa.index.strategies.SpatioTemporalFilterStrategy#isBounded * org.locationtech.geomesa.memory.cqengine.GeoCQEngine#add,#addAll,#remove,#getById,#getReaderForFilter * org.locationtech.geomesa.utils.geotools.RichSimpleFeatureType.RichSimpleFeatureType#setIndexCoverage,#getIndexCoverage,#setBinTrackId,#isBinTrackId,#isIndexed,#getDtgDescriptor,#getStIndexSchema,#setStIndexSchema,#getBinTrackId,#setTableSharing,#setTableSharingPrefix,#getTableSplitter,#getTableSplitterOptions,#setRemoteVersion * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes.Configs various * org.locationtech.geomesa.utils.geotools.sft.SimpleFeatureSpecConfig#normalizeKey * org.locationtech.geomesa.utils.index.SpatialIndex#insert,#remove,#get,#query * org.locationtech.geomesa.utils.stats.DescriptiveStats#attributes * org.locationtech.geomesa.utils.stats.EnumerationStat#attribute * org.locationtech.geomesa.utils.stats.Frequency#attribute,#dtgIndex * org.locationtech.geomesa.utils.stats.GroupBy#attribute,#exampleStat * org.locationtech.geomesa.utils.stats.Histogram#attribute * org.locationtech.geomesa.utils.stats.MinMax#attribute * org.locationtech.geomesa.utils.stats.TopK#attribute * org.locationtech.geomesa.utils.stats.Z3Frequency#geomIndex,#dtgIndex * org.locationtech.geomesa.utils.stats.Z3Histogram#geomIndex,#dtgIndex Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com> * * Additional modules: * geomesa-spark/geomesa-spark-geotools * Additional classes: * org.locationtech.geomesa.index.conf.DigitSplitter * org.locationtech.geomesa.index.conf.NoSplitter * org.locationtech.geomesa.index.conf.AlphaNumericSplitter * org.locationtech.geomesa.index.conf.HexSplitter * org.locationtech.geomesa.spark.jts.util.GeoJSONExtensions * Additional methods: * org.locationtech.geomesa.accumulo.AccumuloVersion#ensureTableExists * org.locationtech.geomesa.accumulo.AccumuloVersion#ensureNamespaceExists * org.locationtech.geomesa.accumulo.data.AccumuloDataStore#DeprecatedSchemaVersionKey * org.locationtech.geomesa.accumulo.data.AccumuloDataStore#tableOps * org.locationtech.geomesa.accumulo.data.AccumuloDataStoreFactory#DISPLAY_NAME * org.locationtech.geomesa.accumulo.data.AccumuloDataStoreFactory#DESCRIPTION * org.locationtech.geomesa.accumulo.util.AccumuloSchemaBuilder.AccumuloUserDataBuilder#tableSharing * org.locationtech.geomesa.fs.storage.common.StorageKeys#PartitionSchemeKey * org.locationtech.geomesa.jobs.mapreduce.GeoMesaOutputFormat#configureDataStore * org.locationtech.geomesa.spark.GeoMesaDataSource#structType2SFT * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes.AttributeOptions various * org.locationtech.geomesa.utils.geotools.SimpleFeatureTypes#getSecondaryIndexedAttributes * org.locationtech.geomesa.utils.index.SpatialIndex#getCenter Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com> * Adding raster and native api removal to upgrade guide
Signed-off-by: Emilio Lahr-Vivaz elahrvivaz@ccri.com