-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEOMESA-3362 Adds optional flattened arrow output #3128
GEOMESA-3362 Adds optional flattened arrow output #3128
Conversation
...esa-arrow-gt/src/main/scala/org/locationtech/geomesa/arrow/io/DictionaryBuildingWriter.scala
Outdated
Show resolved
Hide resolved
...a-arrow-gt/src/test/scala/org/locationtech/geomesa/arrow/io/SimpleFeatureArrowFileTest.scala
Show resolved
Hide resolved
this is a good start, but we also have to add it to the distributed processing code, otherwise it will only work for non-geomesa-native stores (i.e. won't work for accumulo/hbase/etc). i could probably be convinced to only support it for postgis for now, if you don't have the bandwidth to do the rest. |
need to update docs, here at a minimum, I'm not sure if there are other places that reference it. |
Thanks for the review! I'll have the changes and doc updates up soon. If it is ok with you can we keep this change isolated to postgis for now? I can clarify this feature in the docs that it will only work for postgis atm. |
@elahrvivaz I wasn't sure what the best practice is for adding this new parameter across all usage and defaulted pretty much everything to I manually tested against geoserver with these changes and queries look good. |
sorry i haven't had a chance to look at this yet, i'll try to get to it soon. |
...ector/src/main/scala/org/locationtech/geomesa/process/transform/ArrowConversionProcess.scala
Outdated
Show resolved
Hide resolved
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/conf/QueryHints.scala
Outdated
Show resolved
Hide resolved
geomesa-index-api/src/main/scala/org/locationtech/geomesa/index/conf/QueryHints.scala
Outdated
Show resolved
Hide resolved
lgtm, will merge when CI's done |
created https://geomesa.atlassian.net/browse/GEOMESA-3379 as a follow-up to implement for distributed stores. |
Thanks for the merge! Just to confirm did you also see the CO-MR which updates the geoserver plugin code? |
i did, but thanks for reminding me again! |
Ticket: https://geomesa.atlassian.net/browse/GEOMESA-3362
Co-MR: geomesa/geomesa-geoserver#55
Testing
The airports shape file was obtained and loaded into geoserver:
https://hub.arcgis.com/documents/f74df2ed82ba4440a2059e8dc2ec9a5d/explore
Execute the following curl commands which exercise various arrow output options with and without the new flatten parameter.
This python snippit was used for display of the arrow data:
arrow_print.py
Default return:
Output:
With flatten
Output:
Return only desired properties
Output:
Return only desired properties w/ flatten
Output:
Reverse Sort
Output:
Reverse sort w/ flatten
Output: