GEOMESA-1198 Changing attribute table suffix #913
Conversation
Signed-off-by: Emilio Lahr-Vivaz <elahrvivaz@ccri.com>
|
I tested out with old data and with old enabled indices and it still works. |
| @@ -51,7 +51,7 @@ object AttributeTable extends GeoMesaTable with LazyLogging { | |||
| override def supports(sft: SimpleFeatureType) = | |||
| sft.getSchemaVersion > 5 && sft.getAttributeDescriptors.exists(_.isIndexed) | |||
|
|
|||
| override val suffix: String = "attr_idx" | |||
| override val suffix: String = "attr" | |||
There was a problem hiding this comment.
Does this affect 'existing' installations? I'm guessing 'no' since the table name would be configured in the metadata in Accumulo.
There was a problem hiding this comment.
it's back-compatible, yeah. the main bugaboo was if they used the 'enabled.indices' options.
There was a problem hiding this comment.
we do have a couple of places where we used that... @jnh5y see Alec's email 😢 We should probably at least try to do real release notes like accumulo where we can mention things like this.
There was a problem hiding this comment.
just to clarify it will work with enabled.indices - that just was where the complexity in code came in.
|
Ok, looks good to me. |
|
so far looks good. i'll try it with an old one just to make sure. |
|
@jahhulbert-ccri ok, great; then I'm assigning the PR to you. |
Signed-off-by: Emilio Lahr-Vivaz elahrvivaz@ccri.com