-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate custom LazyLogging #2868
Comments
@metasim oops we've removed it already (: I don't think that it was so popular that everybody used it. |
Cool. I keep accidentally using it, but I'm on 2.1.0. |
If you're on 2.1.0 you should use it. In the 2.1.0 typesafe LazyLogging doesn't have a transient logger, that's why we had our own version of the same thing. |
I meant I was on Geotrellis 2.1.0. I'm on ScalaLogging 3.9.0, which properly handles |
geotrellis.util.LazyLogging
was originally necessary mark the logger as@transient
, to ensure that the logger didn't get serialized as a part of a SparkRDD
closure. Modern versions ofcom.typesafe.scalalogging.LazyLogging
properly use the@transient
annotation. Library users should be encouraged to use the officialLazyLogging
over the GeoTrellis one.The migration path (across major GT release) should be:
trait
as@deprecated
and update all of GeoTrellis to use the standard versiongeotrellis.util.LazyLogging
from GeoTrellis.The text was updated successfully, but these errors were encountered: