Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate custom LazyLogging #2868

Closed
metasim opened this issue Feb 7, 2019 · 5 comments
Closed

Deprecate custom LazyLogging #2868

metasim opened this issue Feb 7, 2019 · 5 comments
Labels
technical debt https://en.wikipedia.org/wiki/Technical_debt

Comments

@metasim
Copy link
Member

metasim commented Feb 7, 2019

geotrellis.util.LazyLogging was originally necessary mark the logger as @transient, to ensure that the logger didn't get serialized as a part of a Spark RDD closure. Modern versions of com.typesafe.scalalogging.LazyLogging properly use the @transient annotation. Library users should be encouraged to use the official LazyLogging over the GeoTrellis one.

The migration path (across major GT release) should be:

  1. Mark the trait as @deprecated and update all of GeoTrellis to use the standard version
  2. Remove geotrellis.util.LazyLogging from GeoTrellis.
@metasim metasim added technical debt https://en.wikipedia.org/wiki/Technical_debt blocked and removed blocked labels Feb 7, 2019
@pomadchin
Copy link
Member

@metasim oops we've removed it already (: I don't think that it was so popular that everybody used it.

@pomadchin
Copy link
Member

#2813

@metasim
Copy link
Member Author

metasim commented Feb 7, 2019

Cool. I keep accidentally using it, but I'm on 2.1.0.

@metasim metasim closed this as completed Feb 7, 2019
@pomadchin
Copy link
Member

pomadchin commented Feb 7, 2019

If you're on 2.1.0 you should use it. In the 2.1.0 typesafe LazyLogging doesn't have a transient logger, that's why we had our own version of the same thing.

@metasim
Copy link
Member Author

metasim commented Feb 8, 2019

I meant I was on Geotrellis 2.1.0. I'm on ScalaLogging 3.9.0, which properly handles @transient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt https://en.wikipedia.org/wiki/Technical_debt
Projects
None yet
Development

No branches or pull requests

2 participants