Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide AvroRecordCodec implementations for JTS geometry types #3159

Closed
CloudNiner opened this issue Dec 4, 2019 · 3 comments
Closed

Provide AvroRecordCodec implementations for JTS geometry types #3159

CloudNiner opened this issue Dec 4, 2019 · 3 comments
Labels
avro layers reading/writing spatially indexed layers enhancement needs use case

Comments

@CloudNiner
Copy link
Contributor

We have a few codecs in https://github.com/locationtech/geotrellis/tree/master/store/src/main/scala/geotrellis/store/avro/codecs for things like Extent, but not for the geometry types.

Something like https://github.com/sksamuel/avro4s might make it easier to write and maintain these?

@CloudNiner CloudNiner added enhancement avro layers reading/writing spatially indexed layers labels Dec 4, 2019
@pomadchin
Copy link
Member

pomadchin commented Dec 4, 2019

@CloudNiner I think in our case avro4s will still require to write custom codecs manually https://github.com/sksamuel/avro4s#custom-type-mappings We have complex types and lot's of them are not case classes. Also mb it makes no sense to include codecs we don't use explicitly in the library code? Anything else (like JTS types) is a user-defined code in my opinion, I see no ways how GeoTrellis can use it to persist layers.

But we could have some separate library with JTS Avro codecs / etc.

@pomadchin
Copy link
Member

pomadchin commented Dec 4, 2019

Btw this is a perfect issue for the geotrellis-contrib repo.

@CloudNiner
Copy link
Contributor Author

Ooo great point. Closing this and opened geotrellis/geotrellis-contrib#241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
avro layers reading/writing spatially indexed layers enhancement needs use case
Projects
None yet
Development

No branches or pull requests

2 participants