reprojectExtentAsPolygon should be more deterministic #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
fix/reproject-exception
branch
3 times, most recently
from
019a910
to
9148c5f
Compare
echeipesh
requested changes
Sep 26, 2019
vector/src/main/scala/geotrellis/vector/reproject/Reproject.scala
Outdated
Show resolved
Hide resolved
vector/src/main/scala/geotrellis/vector/reproject/Reproject.scala
Outdated
Show resolved
Hide resolved
pomadchin
force-pushed
the
fix/reproject-exception
branch
from
9148c5f
to
60b7ee8
Compare
…in the reprojectAsPolygon function call Signed-off-by: Grigory <gr.pomadchin@gmail.com>
pomadchin
force-pushed
the
fix/reproject-exception
branch
from
60b7ee8
to
99e639c
Compare
pomadchin
commented
Sep 26, 2019
| @@ -14,9 +14,10 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package geotrellis.vector | |||
| package geotrellis.vector.reproject | |||
There was a problem hiding this comment.
I think we need to review the vector package specs structure in a separate issue @echeipesh.
Test paths here don't correspond to package names.
echeipesh
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves the division by zero unhandled case in the
reprojectExtentAsPolygonfunction,Checklist
docs/CHANGELOG.rstupdated, if necessaryCloses #3023