#3144: MinResample / MaxResample: preserve NODATA correctly for double cell … #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kervel
changed the title
metasim
reviewed
Nov 15, 2019
| @@ -40,7 +40,7 @@ class MaxResample(tile: Tile, extent: Extent, targetCS: CellSize) | |||
| // Double.NaN would *always* be max | |||
| if (isData(v)) math.max(currentMax, v) else currentMax | |||
| } | |||
| if (doubleMax == Double.MinValue) NODATA else doubleMax | |||
| if (doubleMax == Double.MinValue) doubleNODATA else doubleMax | |||
…type. The current code set NODATA for nodata cells, but NODATA is only valid for Int cell types. Double.NaN or doubleNODATA should be used for double cells See #3144 Signed-off-by: Frank Dekervel <frank@kapernikov.com>
|
(oops i broke the tests, now the tests are fixed) |
echeipesh
approved these changes
Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current code set NODATA for nodata cells, but NODATA is only valid for Int cell types. Double.NaN or doubleNODATA should be used for double cells
See #3144
Checklist
docsguides update, if necessaryDemo
Optional. Screenshots/REPL
Notes
Closes #3144