Specialize Grid for Int and Long

[pomadchin]

Overview

scala> val tile = ShortUserDefinedNoDataArrayTile(Array(), 10, 10, ShortUserDefinedNoDataCellType(-1))
tile: geotrellis.raster.ShortUserDefinedNoDataArrayTile = ArrayTile(10,10,int16ud-1)

scala> trait C { def cols: Int = (tile: CellGrid[Int]).cols }
defined trait C

scala> :javap C
  // ...
  public default int cols();
    descriptor: ()I
    flags: (0x0001) ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: getstatic     #71                 // Field $line3/$read$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$.MODULE$:L$line3/$read$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$;
         3: invokevirtual #75                 // Method $line3/$read$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$.tile:()Lgeotrellis/raster/ShortUserDefinedNoDataArrayTile;
         6: invokevirtual #80                 // Method geotrellis/raster/CellGrid.cols$mcI$sp:()I
         9: ireturn
      LineNumberTable:
        line 27: 0
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0      10     0  this   L$line4/$read$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$$iw$C;
  // ...

Checklist

• ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.

Closes #3427

[pomadchin]

[warn] geotrellis/raster/src/main/scala/geotrellis/raster/GridExtent.scala:36:7: class Grid must be a trait. Specialized version of class GridExtent will inherit generic geotrellis.raster.Grid[Int]
[warn] class GridExtent[@specialized(Int, Long) N: Integral](
[warn]       ^
[warn] one warning found

[pomadchin]

scala/bug#8405 Grid should be converted into a trait.

[pomadchin]

Having a specialized trait is enough!

[metasim]

Interesting... That's really good to know.

[pomadchin]

@metasim nope #3429

[pomadchin]

trait Grid[N] extends Serializable

[echeipesh]

Nice bit of detective work.

[metasim]

Thanks so much for doing all this work!