New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate test code for modules with associated testkit to eliminate dependency cycle #3433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07c049e.
…testkit-dagify * commit 'cc806a13c8a5a335eeda63eb0cbb085a8890ccc9': GeoTools fork in tests
metasim
force-pushed
the
feature/testkit-dagify
branch
from
October 28, 2021 13:55
6559db8
to
f8901b9
Compare
metasim
changed the title
Separates test code for modules with associated testkit to eliminate dependency cycle
Separate test code for modules with associated testkit to eliminate dependency cycle
Oct 28, 2021
metasim
force-pushed
the
feature/testkit-dagify
branch
from
November 1, 2021 15:55
97a6e22
to
1e3bce6
Compare
metasim
force-pushed
the
feature/testkit-dagify
branch
7 times, most recently
from
November 9, 2021 16:11
3a08510
to
920f5c9
Compare
Attempt to capture core file on "pure virtual method called".
metasim
force-pushed
the
feature/testkit-dagify
branch
from
November 10, 2021 14:37
920f5c9
to
01a6b7c
Compare
This reverts commit 01a6b7c.
Closing it for now, I feel like to start this PR from scratch will be an easier lift. I feel like there may be another way to solve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The latest version of IntelliJ no longer handles previous workarounds to handle dependency cycle between a module's test scope and it's test-kit.
For example,
sbt
sees this:but IntelliJ sees this: