Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate test code for modules with associated testkit to eliminate dependency cycle #3433

Closed
wants to merge 13 commits into from

Conversation

metasim
Copy link
Member

@metasim metasim commented Oct 25, 2021

Overview

The latest version of IntelliJ no longer handles previous workarounds to handle dependency cycle between a module's test scope and it's test-kit.

For example, sbt sees this:

raster / Test +-> raster-testkit / Compile --> raster / Compile
              |                                ^
              +--------------------------------+

but IntelliJ sees this:

raster / {Test|Compile} --> raster-testkit / Compile --+
                   ^                                   |
                   ------------------------------------+     

@metasim metasim changed the title Separates test code for modules with associated testkit to eliminate dependency cycle Separate test code for modules with associated testkit to eliminate dependency cycle Oct 28, 2021
@metasim metasim force-pushed the feature/testkit-dagify branch 7 times, most recently from 3a08510 to 920f5c9 Compare November 9, 2021 16:11
Attempt to capture core file on "pure virtual method called".
This reverts commit 01a6b7c.
@pomadchin
Copy link
Member

Closing it for now, I feel like to start this PR from scratch will be an easier lift. I feel like there may be another way to solve it?

@pomadchin pomadchin closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants