KMeans improvements (CQL, hull attr, CLI opts) #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfecher
reviewed
Aug 31, 2017
| @@ -102,14 +107,50 @@ public void run() | |||
| queryOptions.setAdapter(featureAdapterIds); | |||
|
|
|||
| // This is required due to some funkiness in GeoWaveInputFormat | |||
| queryOptions.getAdaptersArray(inputDataStore.createAdapterStore()); | |||
| AdapterStore adapterStore = inputDataStore.createAdapterStore(); | |||
| queryOptions.getAdaptersArray(adapterStore); | |||
There was a problem hiding this comment.
really? thats not good if its true
There was a problem hiding this comment.
That's an old comment. I have no idea why it's there. I think I split it out just to get a ref to the adapterStore for reuse farther down.
rfecher
reviewed
Aug 31, 2017
| } | ||
| } | ||
| catch (CQLException e) { | ||
| LOGGER.error("Unable to parse CQL: " + cqlFilter); |
There was a problem hiding this comment.
ideally we'd have a stack trace (ie. add , e); Not worth disapproving the PR jsut for that.
rfecher
reviewed
Aug 31, 2017
| .getFeatureType() | ||
| .getGeometryDescriptor() | ||
| .getLocalName(); | ||
| Filter filter; |
There was a problem hiding this comment.
odd, must have been an artifact of something OBE for these two lines to be separate. iNot worth disapproving the PR just for that.
rfecher
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.