Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Oracle driver from Maven Central #500

Open
yeroc opened this issue Dec 4, 2019 · 4 comments
Open

Use Oracle driver from Maven Central #500

yeroc opened this issue Dec 4, 2019 · 4 comments

Comments

@yeroc
Copy link

yeroc commented Dec 4, 2019

It would simplify things to switch to using the Oracle JDBC driver that has (finally) been published to Maven Central as announced earlier this year at https://medium.com/oracledevs/oracle-jdbc-drivers-on-maven-central-64fcf724d8b.

Maven coordinates:

            <dependency>
                <groupId>com.oracle.ojdbc</groupId>
                <artifactId>ojdbc8</artifactId>
                <version>19.3.0.0</version>
            </dependency>
@jnh5y
Copy link
Contributor

jnh5y commented Dec 4, 2019

As it was hinted at on another issue, the JTS committers aren't presently in a position to make the change and test against a copy of Oracle.

Are you able to contribute that effort? If so, the Contributing guide here (https://github.com/locationtech/jts/blob/master/CONTRIBUTING.md) outlines what you'll need to do in order to submit a PR to address this issue.

@yeroc
Copy link
Author

yeroc commented Dec 4, 2019

I'm happy to open a PR to upgrade the library as this is trivial.

One approach to getting Oracle available for testing may be using a docker container via the TestContainers (https://www.testcontainers.org/modules/databases/oraclexe/) project. However, this requires JUnit 4.x at a minimum. Also, not sure of the maintainers' stance on Docker?

@bsideup
Copy link

bsideup commented Dec 5, 2019

However, this requires JUnit 4.x at a minimum

FYI you can also use container.start() without having to use JUnit at all

@andyjefferson
Copy link

This is included as part of #439. Suggest that you close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants