Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release schedule for 1.17? #510

Closed
3 of 5 tasks
jagill opened this issue Jan 12, 2020 · 17 comments
Closed
3 of 5 tasks

Release schedule for 1.17? #510

jagill opened this issue Jan 12, 2020 · 17 comments

Comments

@jagill
Copy link

jagill commented Jan 12, 2020

Do we have any schedule for releasing 1.17 (or a bugfix 1.16.2)? In addition to bug #490, there's blocking bug for me that is fixed on master but not in 1.16.1. For a Presto release, we'd need to pin to a released version of JTS.

For context, the bug is an off-by-one error in PackedCoordinateSequence that causes an IndexOutOfBounds exception.


Release activities from RELEASING.md

  • update release notes (see JTS_Version_History )
  • experiment: review fixed issue and assign to 1.17.0 milestone
  • release process (resulting in a tag)
  • submit for eclipse foundation review (a two week window for feedback)
  • release to maven central
@dr-jts
Copy link
Contributor

dr-jts commented Jan 13, 2020

No release schedule yet, but it is probably time for a release.

@jagill
Copy link
Author

jagill commented Feb 20, 2020

Just following up. It seems like there's been a bunch of awesome bug fixes since 1.16.1 (and some unblock me). Should we set a release schedule?

@dmitrykinakh
Copy link

@dr-jts - when we can expect a new release? In my project, I'm using jts-core-1.15.0-SNAPSHOT version but have an issue with that at it eat 100% CPU. Hoping new version can fix that.

@dr-jts
Copy link
Contributor

dr-jts commented Mar 12, 2020

@dmitrykinakh I'm intending to release 1.17 before FOSS4G in August.

If you have a problem with 1.15 perhaps you should try 1.16.1?

@jnh5y
Copy link
Contributor

jnh5y commented Mar 12, 2020

@dr-jts Good to hear a schedule like that. Is there a timeline that we should fire up some testing with GeoTools and GeoServer?

@dmitrykinakh
Copy link

@dr-jts I've already tried that, unfortunately, indexing 400 items (and even 100) per batch in 3 million datasets still lead to 100% CPU usage.

@mprins
Copy link
Contributor

mprins commented Mar 13, 2020

@dmitrykinakh Did you try with a JTS snapshot build in your project?

You only need to add https://repo.locationtech.org/content/repositories/jts-snapshots/ as a snapshot repo to your project and you can use 1.17.0-SNAPSHOT

@dmitrykinakh
Copy link

dmitrykinakh commented Mar 13, 2020

@mprins - thanks for your comment.

I'm not really good at DevOps staff and yesterday did this as a quick test.
image

Is this link is a valid one for the recent 1.17 snapshot?
https://repo.eclipse.org/content/repositories/jts-snapshots/org/locationtech/jts/jts-core/1.17.0-SNAPSHOT/

@mprins
Copy link
Contributor

mprins commented Mar 13, 2020

that is the correct directory, yes; you'll notice that artifacts are timestamped.

it looks like you are not building a Maven project, but constructing a solr docker image, so I can't help you there. Also not clear why you think a newer version of JTS would fix your problem with solr?

@dmitrykinakh
Copy link

I'm not sure if newer JTS will fix my issue but what I'm sure about is that I have a 100% CPU usage when I index data with geometry (polygons) and have low CPU usage (25-30%) when I turn off geometry field from indexing.

So, I just want to try of I'll get some improvements in terms of performance with a new version of JTS as it's used to index geometry.

@jnh5y
Copy link
Contributor

jnh5y commented Mar 16, 2020

@dmitrykinakh The Solr and Lucene communities have implemented various other geospatial capabilities some of which use JTS and some which eschew it. It may be worthwhile to get in touch with those communities about your speed concerns. If JTS is used, they can explain how and discuss options for improving performance.

@jnh5y
Copy link
Contributor

jnh5y commented Mar 16, 2020

Also, since @mprins mentioned it, I wanted to own to the fact that the JTS nightly snapshot builds are broken. It is on my list to address this, but I'm behind on knocking it out.

@dmitrykinakh
Copy link

@jnh5y - could you mention/link me with any of the community that can help me to debug my issue with indexing geometry?

@jnh5y
Copy link
Contributor

jnh5y commented Mar 17, 2020

@dmitrykinakh Sorry I don't have any particular pointers. I'd suggest just asking on any Solr user lists, etc.

@jodygarnett
Copy link
Contributor

@jagill as you were kind enough to provide this bug, I would like to use it to coordinate the release :)

If you are available to help test that would be appreciated.

@jodygarnett jodygarnett added this to the 1.17.0 milestone Jun 16, 2020
@jagill
Copy link
Author

jagill commented Jun 16, 2020

@jodygarnett I'm happy to check that the new version fixes the issues I mentioned. Additionally, I'd be happy to run the release version through our Presto test suite, which tests many standard and edge cases, and also the verifier, which will randomly select thousands of queries for any correctness changes or significant performance regressions.

@jagill
Copy link
Author

jagill commented Jul 2, 2020

@jodygarnett I checked, and 1.17.0 fixes the issues I mentioned before. The results from buffer seem to have changed by a small amount -- some double coordinates have changed by about 1e-15 or so. Well within tolerance, of course, but enough that verifying results will be a bit more effort.

I haven't been able to run this on our verifier geospatial query suite, but I hope to get that done as soon as the slots open up.

@dr-jts dr-jts closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants