Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary compatibility with 1.16 #805

Open
i23098 opened this issue Nov 25, 2021 · 2 comments
Open

Binary compatibility with 1.16 #805

i23098 opened this issue Nov 25, 2021 · 2 comments

Comments

@i23098
Copy link

i23098 commented Nov 25, 2021

The change in JTS 1.17 makes it impossible to use newer version of JTS because it's not binary compatible

java.lang.NoSuchMethodError: org.locationtech.jts.geom.Polygon.getExteriorRing()Lorg/locationtech/jts/geom/LineString;

And, even though it's a simple recompile, when it's a dependency of a dependency of a dependency, it can be harder to have it all working well together (e.g. wdtinc/mapbox-vector-tile-java#48 did not make any new release).

An even simpler solution would be keeping binary compatibility. That could be achieve would a bridge method as described in https://www.morling.dev/blog/refining-return-type-java-methods-without-breaking-backwards-compatibility/

@moving-bits
Copy link

Thumbs up for this issue, as we are stuck in the dependency problem as well:

We are using a dependency which itself uses jts-core. Our dependency tries to stay Java 7-compatible, therefore still stays with jts-core 0.15, whereas our app supports Java 8 and we generally try to use most-recent versions of our included dependencies (to have bug fixes and other improvements included). Due to the breaking interface change in 0.17 we cannot update, though, in this case.

Any chance to get this back to binary compatible in a future version?

@mprins
Copy link
Contributor

mprins commented Jun 26, 2022

the reason for the improvement / API change is well documented in the pull request: #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants