Fix inverse datum shifting when coordinate is not exactly on a grid point #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
approved these changes
Apr 3, 2022
There was a problem hiding this comment.
Hey @rhuitl, gz with your first contribution and thanks for making this PR with a nice descirption. 🎉 I can merge it once the CI is green and all checks passed.
May I ask you to sign ECA please to make Eclipse license checker happy?
Eclipse grabs your name and email from the commit, so doublecheck that you commited under the correct email (that was used to sign ECA), right now the ECA is required for the Anonymous (git@****.de) email).
|
Hi @pomadchin, thank you for the prompt reply. I signed the ECA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as the one proposed in dwins/proj4j#3, which never got merged.
It aligns the
nad_intrmethod in this repository with the original one from the C implementation: https://github.com/OSGeo/PROJ/blob/4.9/src/nad_intr.c#L54.Further confirmation that this code is indeed missing: the Proj4JS implementation does this similarly: https://github.com/proj4js/proj4js/blob/master/lib/datum_transform.js#L187.