Master #65
Merged
Master #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,7 +118,7 @@ protected function getServiceUri() | |||
| { | |||
| $uri = GeneralUtility::getIndpEnv('TYPO3_REQUEST_URL'); | |||
| $parts = parse_url($uri); | |||
| $parts['query'] = 'eID=JsonServer&server=' . $this->serverKey; | |||
| $parts['query'] = 'eID=JsonServer&server=' . $this->serverKey; | |||
There was a problem hiding this comment.
Why you reset this change: #59
?
There was a problem hiding this comment.
I saw you explicit set this: fed22a5
So I merge your example extension.... thanks
There was a problem hiding this comment.
I did change it in the SoapServer, but in the JsonServer it is wrong.
So SoapServer needs encoded Ampersand, but JsonServer does not.
#59 is the SoapServer change. Here it is changed in the JsonServer
There was a problem hiding this comment.
Ahh... thanks for your contribution. Patch is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JsonServer example