Fix Bug that removes JS and CSS #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks... merged this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this great extension.
I encountered a strange bug there all the JS and CSS was missing from a page.
This only happens under certain circumstances.
We have a huge data attribute in our output. It holds over 3MB of JSON.
With that, the preg_split in line 189 returns false.
https://github.com/lochmueller/sourceopt/blob/master/Classes/Service/CleanHtmlService.php#L189
And there is the problem, the JS and CSS was removed from $html and is not added back to the return in line 197.
https://github.com/lochmueller/sourceopt/blob/master/Classes/Service/CleanHtmlService.php#L197