Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging with i18next-gettext-converter again #8

Open
perrin4869 opened this issue Aug 15, 2022 · 4 comments
Open

Consider merging with i18next-gettext-converter again #8

perrin4869 opened this issue Aug 15, 2022 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@perrin4869
Copy link
Collaborator

@adrai I just released i18next-gettext-converter@13.1.0 which upgrades to gettext-parser@6 fresh off the oven.
This new version of gettext-parser upgraded to readable-stream@4 which removes the circular dependency that was causing trouble when packing it for browser consumption. (see: smhg/gettext-parser#63, nodejs/readable-stream#348).
This means that it might be possible to use one of the packages again, instead of having to maintain two separate packages (and maintaining a copy of gettext-parser here).
Maybe you could try replacing this package with i18next-gettext-converter@13.1.0 and see if you encounter any issues sometime?

@adrai
Copy link
Contributor

adrai commented Aug 15, 2022

hmmm... can't just use i18next-gettext-converter, this module is not only offering the i18next conversions, but also non-i18next...
but it might be we can reuse the official gettext-parser again...

@adrai
Copy link
Contributor

adrai commented Aug 15, 2022

made a quick test... and tried to run the existing tests... half of them fail...
will postpone this topic in to the future ;-)

@adrai adrai added enhancement New feature or request question Further information is requested labels Aug 15, 2022
@perrin4869
Copy link
Collaborator Author

Maybe the tests are failing because of this change?
smhg/gettext-parser#72
I had to adjust some tests in i18next-gettext-converter.
Anyways nothing urgent, just think it'll be nice to tidy things up!

@adrai
Copy link
Contributor

adrai commented Aug 15, 2022

no, not just that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants