Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pocompiler: add trailing newline #72

Merged
merged 2 commits into from
Aug 12, 2022
Merged

pocompiler: add trailing newline #72

merged 2 commits into from
Aug 12, 2022

Conversation

kevinlul
Copy link
Contributor

@kevinlul kevinlul commented Aug 7, 2022

This makes the file POSIX-compliant, which is also the original ecosystem that gettext comes from.

This makes the file POSIX-compliant, which is also the original ecosystem that gettext comes from.
@smhg
Copy link
Owner

smhg commented Aug 9, 2022

@kevinlul Thank you for your contribution! I wasn't aware these were missing.
You definitely need to run the tests (and linting) when we move on with this (npm run lint and npm test). Can you have a look at that?

@kevinlul
Copy link
Contributor Author

Side note: the tests on Windows seem to assume .gitattributes * text=auto, or at least for *.po and *.pot. They don't work if Git checks out the files with the original LF endings instead of converting them to CR LF!

@smhg
Copy link
Owner

smhg commented Aug 11, 2022

Side note: the tests on Windows seem to assume .gitattributes * text=auto, or at least for *.po and *.pot. They don't work if Git checks out the files with the original LF endings instead of converting them to CR LF!

I'm not experienced enough with Git: is this something that we can fix? Can you add it to this PR?

@kevinlul
Copy link
Contributor Author

Yes, I'll make a separate PR as it's not specifically related to this issue. This one should be done unless you spot any other problems?

@smhg smhg merged commit 598dcb4 into smhg:master Aug 12, 2022
@smhg
Copy link
Owner

smhg commented Aug 12, 2022

Thank you! Released as 6.0.0.
Feel free to send that additional PR.

@kevinlul kevinlul deleted the patch-1 branch August 13, 2022 01:02
kevinlul added a commit to kevinlul/gettext-parser that referenced this pull request Aug 13, 2022
@kevinlul kevinlul mentioned this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants