Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(install): binary install not working #77

Closed
4 tasks done
chrillep opened this issue Sep 13, 2022 · 15 comments
Closed
4 tasks done

bug(install): binary install not working #77

chrillep opened this issue Sep 13, 2022 · 15 comments

Comments

@chrillep
Copy link

chrillep commented Sep 13, 2022

for some reason the shell script isn't working.

curl -fsSL https://raw.githubusercontent.com/locize/locize-cli/master/install.sh | sh

debugged it to these lines .
something is wrong at github perhaps :/

locize-cli/install.sh

Lines 29 to 34 in 8bb0061

locize_asset_path=$(
command curl -sSf https://github.com/locize/locize-cli/releases |
command grep -o "/locize/locize-cli/releases/download/.*/locize-${os}" |
command head -n 1
)
if [ ! "$locize_asset_path" ]; then exit 1; fi

maybe log / output something if finding releases fail instead of just exit? :)

if [ ! "$locize_asset_path" ]; then
    echo "failed to find a release"
    exit 1;
fi

works on.

ref:

One Liner to Download the Latest Release from Github Repo.md

@chrillep
Copy link
Author

chrillep commented Sep 13, 2022

relates to #76

@adrai
Copy link
Collaborator

adrai commented Sep 13, 2022

yes, it looks github changed the way the html is returned... looks like to be a lazy loaded fragment now... will investigate...
// cc @shinpou

@chrillep
Copy link
Author

yeah i was depending on this script so maybe ill just lock to a release version instead :)

@shinkathe
Copy link

Is there any possibility of maybe using https://github.com/locize/locize-cli/releases/latest always if the version parameter is not provided? I guess using the github api is out of the question considering it requires authentication...

adrai added a commit that referenced this issue Sep 13, 2022
@adrai
Copy link
Collaborator

adrai commented Sep 13, 2022

just fixed the install.sh script

@chrillep
Copy link
Author

chrillep commented Sep 13, 2022

Is there any possibility of maybe using https://github.com/locize/locize-cli/releases/latest always if the version parameter is not provided? I guess using the github api is out of the question considering it requires authentication...

curl -s https://api.github.com/repos/locize/locize-cli/releases/latest

seems to work, so does

curl -s https://api.github.com/repos/locize/locize-cli/releases

maybe since its and public repo

https://gist.github.com/steinwaywhw/a4cd19cda655b8249d908261a62687f8

@chrillep
Copy link
Author

just fixed the install.sh script

ill try it thanks

@chrillep
Copy link
Author

chrillep commented Sep 13, 2022

ty works on.

  • macos
  • alpine

@shinkathe
Copy link

install.ps1 still fails for me, appears to break on this part:

    $Response.Links |
      Where-Object { $_.href -like "/locize/locize-cli/releases/download/*/locize-${OS}" } |
      ForEach-Object { 'https://github.com' + $_.href } |
      Select-Object -First 1

This part returns a null, so same cause as this issue

@adrai
Copy link
Collaborator

adrai commented Sep 13, 2022

just fixed sh... currently checking ps1 ;-)

@chrillep
Copy link
Author

@adrai sry but running into this again
but now i get the error message! =)

curl -fsSL https://raw.githubusercontent.com/locize/locize-cli/master/install.sh | sh
curl: no URL specified!
curl: try 'curl --help' or 'curl --manual' for more information
failed to find a release on github

@adrai
Copy link
Collaborator

adrai commented Sep 15, 2022

OMG, they just changed it again....

@chrillep
Copy link
Author

OMG, they just changed it again....

yeah i hear u :/

@adrai
Copy link
Collaborator

adrai commented Sep 15, 2022

ok, now it should work

@chrillep
Copy link
Author

ok, now it should work

yep ty. hopefully they don't change this again anytime soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants