Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run server on a regular tokio task in tests #323

Merged
merged 1 commit into from
May 1, 2024
Merged

Run server on a regular tokio task in tests #323

merged 1 commit into from
May 1, 2024

Commits on Apr 29, 2024

  1. Run server on a regular tokio task in tests 

    I missed this in my original client implementation. Using
`spawn_blocking` means that tests tend to not terminate if something
goes wrong, but the server _is_ async, so that is just completely
unnecessary. This neatly handles panics in tasks and properly finishes
the test if something goes wrong.
    @einarmo
    einarmo committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    45ba160 View commit details
    Browse the repository at this point in the history