Various improvements #8
Conversation
…ed to be more robust
1 similar comment
|
I keep URLS uppercase as it avoids naming collisions with some functions that exist in different packages. I'd prefer it to stay as is if that's ok. |
|
This could be merged but I still get a failing build on OSX R devel (see this log for instance) because of missing dependencies, and I still wasn't able to reproduce the CRAN error. |
|
|
Travis fail? https://travis-ci.org/stephlocke/HIBPwned/jobs/358321151 |
|
the Travis fail seems to be a Travis issue (it fails to install dependencies on Mac R devel). I could investigate it or remove the Mac R devel build from the matrix? |
|
Yeah, I don't really care all that much about mac ;) |
| Imports: | ||
| httr, | ||
| urltools, | ||
| jsonlite, | ||
| ratelimitr | ||
| RoxygenNote: 6.0.1 |
There was a problem hiding this comment.
Any reason why you've incremented for the dev version here?
There was a problem hiding this comment.
No I should change this
There was a problem hiding this comment.
Now I know I have a reason 😿
| VignetteBuilder: knitr | ||
| URL: https://github.com/stephlocke/HIBPwned |
There was a problem hiding this comment.
Maybe better to just refer to the pkgdown site
There was a problem hiding this comment.
One can do both, and as a potential contributor and stargazer I prefer seeing the repo ☺
There was a problem hiding this comment.
But we have the github in the bugs field, but meh, I don't have particularly strong feelings about this so sure thing, we'll go with both
Next time I should try to use gitflow. 👼
I am not able yet to reproduce the error from CRAN 😢 In the latest Travis build the failing job is the one on R devel on OSX... https://travis-ci.org/maelle/HIBPwned/builds/356264582
I have added some trying and waiting in utils.R
I have added grouping to the reference in the pkgdown website
I have taken the freedom to use
stylerandlintrto mostly shorten lines, add space, and rename "URLS" to "urls" (I added exceptions for non snake case function names)