Add check for name length (#98)

lockedata · Dec 28, 2018 · 23bccb8 · 23bccb8
1 parent c0fd68d
commit 23bccb8
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 0 deletions.
diff --git a/R/createAnalysisProject.R b/R/createAnalysisProject.R
@@ -35,6 +35,7 @@ createAnalysisProject <- function(name, title = NULL,
                                   dirs = c("data", "analysis", "outputs")) {
   if (missing(name)) stop("name is required")
   if (!is.character(name)) stop("name has to be a character")
+  if (nchar(name) < 2) stop("name needs to have at least two characters")
 
   packagedeps <- match.arg(packagedeps, okpackagedeps())
 

diff --git a/R/createBasicProject.R b/R/createBasicProject.R
@@ -53,6 +53,7 @@ createBasicProject <- function(name,
                                reset = TRUE) {
   if (missing(name)) stop("name is required")
   if (!is.character(name)) stop("name has to be a character")
+  if (nchar(name) < 2) stop("name needs to have at least two characters")
 
   packagedeps <- match.arg(packagedeps, okpackagedeps())
 

diff --git a/R/createPackageProject.R b/R/createPackageProject.R
@@ -54,6 +54,7 @@ createPackageProject <- function(name, title = NULL,
                                  )) {
   if (missing(name)) stop("name is required")
   if (!is.character(name)) stop("name has to be a character")
+  if (nchar(name) < 2) stop("name needs to have at least two characters")
 
   # create title
   if (is.null(title)) {

diff --git a/R/createTrainingProject.R b/R/createTrainingProject.R
@@ -41,6 +41,7 @@ createTrainingProject <- function(name, folder = getwd(),
                                   reset = TRUE) {
   if (missing(name)) stop("name is required")
   if (!is.character(name)) stop("name has to be a character")
+  if (nchar(name) < 2) stop("name needs to have at least two characters")
 
   packagedeps <- match.arg(packagedeps, okpackagedeps())
   # Supported packages

diff --git a/tests/testthat/test-AAA-createBasicProject.R b/tests/testthat/test-AAA-createBasicProject.R
@@ -23,6 +23,14 @@ test_that("createBasicProject() errors if name missing or not correct", {
     git = TRUE,
     external_setup = NULL
   ))
+
+  expect_error(createBasicProject(
+    name = "a",
+    folder = tmp,
+    packagedeps = "packrat",
+    git = TRUE,
+    external_setup = NULL
+  ))
 })
 
 

diff --git a/tests/testthat/test-createAnalysisProject.R b/tests/testthat/test-createAnalysisProject.R
@@ -23,6 +23,14 @@ test_that("createAnalysisProject() errors if name missing or not correct", {
     git = TRUE,
     external_setup = NULL
   ))
+
+  expect_error(createAnalysisProject(
+    name = "a",
+    folder = tmp,
+    packagedeps = "packrat",
+    git = TRUE,
+    external_setup = NULL
+  ))
 })
 
 

diff --git a/tests/testthat/test-createPackageProject.R b/tests/testthat/test-createPackageProject.R
@@ -33,6 +33,14 @@ test_that("createPackageProject() errors if name missing or not correct", {
     git = TRUE,
     external_setup = NULL
   ))
+
+  expect_error(createPackageProject(
+    name = "a",
+    folder = tmp,
+    packagedeps = "packrat",
+    git = TRUE,
+    external_setup = NULL
+  ))
 })
 
 

diff --git a/tests/testthat/test-createTrainingProject.R b/tests/testthat/test-createTrainingProject.R
@@ -22,6 +22,14 @@ test_that("createTrainingProject() errors if name missing or not correct", {
     git = TRUE,
     external_setup = NULL
   ))
+
+  expect_error(createTrainingProject(
+    name = "a",
+    folder = tmp,
+    packagedeps = "packrat",
+    git = TRUE,
+    external_setup = NULL
+  ))
 })