Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 1.13 Support #129

Merged
merged 3 commits into from
Aug 27, 2015
Merged

Ember 1.13 Support #129

merged 3 commits into from
Aug 27, 2015

Conversation

Kilowhisky
Copy link
Contributor

Extends #124

To add support for ember 1.13+

This has two failing tests that i think should just be removed.

Chris Rice added 3 commits July 2, 2015 08:34
…e instead of direct comparison. This fixes issue where each model has their own declared model adapter like ember-cli now requires. References issue: locks#68
@alexandre-melard
Copy link

I, I'm interested by you pull request. Could you let me know how to use it in my project please? I make heavy use of the local storage adapter in my application, but I am thinking of switching to something more reliable as I have tons of problems every time I update my project.

@Kilowhisky
Copy link
Contributor Author

You can just change the local storage adapter reference line in the package.json file to use my branch until this gets pulled or another one comes along and gets merged into the main.

"ember-localstorage-adapter": "git://github.com/Kilowhisky/ember-localstorage-adapter.git#ember-1.13.+",

@alexandre-melard
Copy link

Tank you for your help!
Le sam. 22 août 2015 à 01:44, Kilowhisky notifications@github.com a
écrit :

You can just change the local storage adapter reference line in the
package.json file to use my branch until this gets pulled or another one
comes along and gets merged into the main.

"ember-localstorage-adapter": "git://github.com/Kilowhisky/ember-localstorage-adapter.git#ember-1.13.+",


Reply to this email directly or view it on GitHub
#129 (comment)
.

@alexandre-melard
Copy link

I get an error when trying to install:

$ npm install --save-dev "
https://github.com/Kilowhisky/ember-localstorage-adapter.git#ember-1.13.+"

npm ERR! Command failed: git -c core.longpaths=true clone
--template=C:\Users\alex\AppData\Roaming\npm-cache_git-remotes_templates
--mirror git@github.com:Kilowhisky/ember-localstorage-adapter.git
C:\Users\alex\AppData\Roaming\npm-cache_git-remotes\git-github-com-Kilowhisky-ember-localstorage-adapter-git-dc5accbf
npm ERR! Clonage dans le dépôt nu
'C:\Users\alex\AppData\Roaming\npm-cache_git-remotes\git-github-com-Kilowhisky-ember-localstorage-adapter-git-dc5accbf'
npm ERR! Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.

Do you have any idea where it's from?

Thanks for your help if you mind to share some time on this

On 22 August 2015 at 08:47, Alexandre Melard alexandre@melard.fr wrote:

Tank you for your help!

Le sam. 22 août 2015 à 01:44, Kilowhisky notifications@github.com a
écrit :

You can just change the local storage adapter reference line in the
package.json file to use my branch until this gets pulled or another one
comes along and gets merged into the main.

"ember-localstorage-adapter": "git://github.com/Kilowhisky/ember-localstorage-adapter.git#ember-1.13.+",


Reply to this email directly or view it on GitHub
#129 (comment)
.

@kurko
Copy link
Collaborator

kurko commented Aug 27, 2015

@Kilowhisky merging. Any chance you can PR a fix for those deprecations? 😄

kurko added a commit that referenced this pull request Aug 27, 2015
@kurko kurko merged commit c321b47 into locks:master Aug 27, 2015
@Kilowhisky Kilowhisky deleted the ember-1.13.+ branch August 28, 2015 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants