Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getters for constraint bounds #1180

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

skleff1994
Copy link
Contributor

@skleff1994 skleff1994 commented Nov 10, 2023

The current API does not set the action model bounds as emphasized in #1170 . This PR fixes this bug by making the corresponding getters virtual .

Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this, @skleff1994!

@cmastalli cmastalli merged commit 2542fa8 into loco-3d:devel Nov 11, 2023
10 checks passed
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jan 27, 2024
Upstream changes:

    ## [2.0.2] - 2023-12-07

    * Added nu, ng, and nh setters for Python bindings in loco-3d/crocoddyl#1192
    * Added CHANGELOG.md in loco-3d/crocoddyl#1188
    * Supported nu==0 in actuation models in loco-3d/crocoddyl#1188
    * Included Python bindings for Crocoddyl exceptions by cmastalli in loco-3d/crocoddyl#1186
    * Updated cmake submodule update by jcarpentier in loco-3d/crocoddyl#1186
    * Fixed getters for contraints bounds by skleff1994 in loco-3d/crocoddyl#1180
    * Extended solver abstract and callbacks for arbitrary solvers by cmastalli in loco-3d/crocoddyl#1179
    * Fixed the check of pair_id in collision residual by ArthurH91 in loco-3d/crocoddyl#1178
    * Exploited control-residual structure when computing Lu, Luu by cmastalli in loco-3d/crocoddyl#1176
    * Added LWA fram convention and introduced different axis for 1d contacts by skleff1994 in loco-3d/crocoddyl#1172
    * Python bindings for setting control bounds by cmastalli in loco-3d/crocoddyl#1171
    * Fixed missed scalar in cost sum and activation data by cmastalli in loco-3d/crocoddyl#1165
    * Added actuation unit tests by cmastalli in loco-3d/crocoddyl#1161
    * Introduced method for obtaining the dimension of floating-bases by cmastalli in loco-3d/crocoddyl#1160
    * Fixed set_reference in state residual by cmastalli in loco-3d/crocoddyl#1158
    * Enabled CONDA CI jobs with CppADCodeGen by cmastalli in loco-3d/crocoddyl#1156
    * Added other CI jobs by cmastalli in loco-3d/crocoddyl#1152
    * Fixed compiltation issue when building with CppADCodeGen by cmastalli in loco-3d/crocoddyl#1151
    * Fixed include order used in frames.cpp by ManifoldFR in loco-3d/crocoddyl#1150
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jan 29, 2024
Upstream changes:

    ## [2.0.2] - 2023-12-07

    * Added nu, ng, and nh setters for Python bindings in loco-3d/crocoddyl#1192
    * Added CHANGELOG.md in loco-3d/crocoddyl#1188
    * Supported nu==0 in actuation models in loco-3d/crocoddyl#1188
    * Included Python bindings for Crocoddyl exceptions by cmastalli in loco-3d/crocoddyl#1186
    * Updated cmake submodule update by jcarpentier in loco-3d/crocoddyl#1186
    * Fixed getters for contraints bounds by skleff1994 in loco-3d/crocoddyl#1180
    * Extended solver abstract and callbacks for arbitrary solvers by cmastalli in loco-3d/crocoddyl#1179
    * Fixed the check of pair_id in collision residual by ArthurH91 in loco-3d/crocoddyl#1178
    * Exploited control-residual structure when computing Lu, Luu by cmastalli in loco-3d/crocoddyl#1176
    * Added LWA fram convention and introduced different axis for 1d contacts by skleff1994 in loco-3d/crocoddyl#1172
    * Python bindings for setting control bounds by cmastalli in loco-3d/crocoddyl#1171
    * Fixed missed scalar in cost sum and activation data by cmastalli in loco-3d/crocoddyl#1165
    * Added actuation unit tests by cmastalli in loco-3d/crocoddyl#1161
    * Introduced method for obtaining the dimension of floating-bases by cmastalli in loco-3d/crocoddyl#1160
    * Fixed set_reference in state residual by cmastalli in loco-3d/crocoddyl#1158
    * Enabled CONDA CI jobs with CppADCodeGen by cmastalli in loco-3d/crocoddyl#1156
    * Added other CI jobs by cmastalli in loco-3d/crocoddyl#1152
    * Fixed compiltation issue when building with CppADCodeGen by cmastalli in loco-3d/crocoddyl#1151
    * Fixed include order used in frames.cpp by ManifoldFR in loco-3d/crocoddyl#1150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants